Fix trashcan cleaner job #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds), in TrashcanCleanerJob.java Signed-off-by: Edmond Kacaj <[email protected]>
Signed-off-by: Edmond Kacaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @torsten-simon
TrashcanCleanerJob.java, use timeToKeep in milliseconds, and this is confusing to users who will use this job,
So in this pull request, I refactor the code, and instead of using milliseconds, Now, we will use DAYS_TO_KEEP which is in DAY.
I also add some Descriptions in order to be easier for users who will use this JOB.
Best regards
Edmond