-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: set fail-fast as False to allow integration tests to continue on nightly Tutor failures #308
ci: set fail-fast as False to allow integration tests to continue on nightly Tutor failures #308
Conversation
ba14453
to
45e66d4
Compare
For more context on this solution, see eduNEXT/eox-tenant#232 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magajh! This change affects all Tutor versions, right? For example, if v18 integration tests fail, do the other versions still run?
That's correct @BryanttV. I couldn't find a way to continue the execution for the other tutor_versions in the matrix only if 'nightly' fails. The use of |
@magajh, Could you try this? I don't know if it works jobs:
integration-test:
name: Tutor Integration Tests
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
tutor_version: ['<18.0.0', '<19.0.0']
experimental: [false]
include:
- version: 'nightly'
experimental: true I was guided by this docs. However, if it doesn't work or we don't want to complicate things, it seems to me that the current solution is a good one. |
@BryanttV Thanks for the suggestion! Since we’re only applying Using That said, one limitation of |
@mariajgrimaldi @BryanttV @jignaciopm this is ready for the final review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @magajh
e0a5db7
to
eab05b7
Compare
eab05b7
to
5c1908e
Compare
Description
This PR updates the Tutor Integration Tests workflow to ensure that failures in the nightly version of Tutor do not cancel the execution of tests for stable versions (<18.0.0 and <19.0.0).
fail-fast: false
is added to the strategy, allowing the workflow to proceed even if nightly fails.This change is important because the nightly version of Tutor is not stable and may occasionally fail due to issues unrelated to our tests. By implementing this update, we ensure that failures in nightly do not block critical tests for stable versions.