-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use tutor config on codejail service and add patches to edit it DS-894 #55
Conversation
cd33297
to
5693dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bra-i-am, thanks for your feedback and for noting the inconsistent information in the dev environments. I already fixed it. Can you check to make sure it worked as expected? |
@MaferMazu, thanks a lot for the fix, I confirm everything is working! |
Thanks for the feedback. Can you review this again @MoisesGSalas? |
Description
This PR aims to solve issue #44 by changing the
FLASK_APP_SETTINGS
variable to use the tutor file and adding patches to edit the configuration values.How to test it
tutor dev/local do init --limit codejail
.tutor config save
tutor dev/local start codejailservice
flask shell
app.config['NAME_OF_YOUR_VARIABLE']
Other information
How to create a patch
You can clone this plugin and add a file with the patch name, and inside the file, add the Python configuration. The file needs to be inside the patches folder: https://github.com/eduNEXT/tutor-contrib-codejail/tree/main/tutorcodejail/patches. You should have something like tutorcodejail/patches/codejail-common-settings, and inside:
Or you can add the patch in another plugin following this documentation: https://docs.tutor.edly.io/tutorials/plugin.html#modifying-existing-files-with-patches