Skip to content

Commit

Permalink
reduce estim_diff example runtime
Browse files Browse the repository at this point in the history
  • Loading branch information
eduardklap committed Aug 23, 2024
1 parent 8b4c9ef commit 6a98a8a
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 23 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
^Meta$
^CITATION\.cff$
^cran-comments\.md$
^CRAN-SUBMISSION$
2 changes: 1 addition & 1 deletion R/estim_diff.R
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#' @examples
#' data_feedback <- feedback
#' estim_diff(data_feedback,
#' c("mfg_learning", "mfg_application"), 20:271,
#' c("mfg_learning", "mfg_application"), 20:71,
#' 10, "Feedback middle frontal gyrus")
#' @export

Expand Down
32 changes: 11 additions & 21 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ editor_options:
wrap: 72
---

## Resubmission

This is a resubmission. In this version I have:

- adapted the examples that exceeded the \> 5s runtime

## R CMD check results

0 errors \| 0 warnings \| 1 note
Expand All @@ -14,45 +20,29 @@ editor_options:

#### Notes returned after running `devtools::check(remote = TRUE, manual = TRUE)`:

❯ checking CRAN incoming feasibility ... [5s/18s] NOTE Maintainer:
❯ checking CRAN incoming feasibility ... [4s/13s] NOTE Maintainer:
‘Eduard Klapwijk
[et.klapwijk\@gmail.com](mailto:[email protected]){.email}’

New submission

❯ checking examples ... [14s/14s]NOTE

Examples with CPU (user + system) or elapsed time \> 5s

user system elapsed

estim_diff 10.222 0.424 10.657

❯ checking HTML version of manual ... NOTE

Found the following HTML validation problems:

`estim_corr.html:4:1 (estim_corr.Rd:5): Warning: <link> inserting "type" attribute estim_corr.html:12:1 (estim_corr.Rd:5): Warning: <script> proprietary attribute "onload" estim_corr.html:12:1 (estim_corr.Rd:5): Warning: <script> inserting "type" attribute estim_corr.html:17:1 (estim_corr.Rd:5): Warning: <table> lacks "summary" attribute estim_corr.html:36:1 (estim_corr.Rd:10): Warning: <table> lacks "summary" attribute estim_diff.html:4:1 (estim_diff.Rd:5): Warning: <link> inserting "type" attribute estim_diff.html:12:1 (estim_diff.Rd:5): Warning: <script> proprietary attribute "onload" estim_diff.html:12:1 (estim_diff.Rd:5): Warning: <script> inserting "type" attribute estim_diff.html:17:1 (estim_diff.Rd:5): Warning: <table> lacks "summary" attribute estim_diff.html:37:1 (estim_diff.Rd:10): Warning: <table> lacks "summary" attribute feedback.html:4:1 (feedback.Rd:6): Warning: <link> inserting "type" attribute feedback.html:12:1 (feedback.Rd:6): Warning: <script> proprietary attribute "onload" feedback.html:12:1 (feedback.Rd:6): Warning: <script> inserting "type" attribute feedback.html:17:1 (feedback.Rd:6): Warning: <table> lacks "summary" attribute gambling.html:4:1 (gambling.Rd:6): Warning: <link> inserting "type" attribute gambling.html:12:1 (gambling.Rd:6): Warning: <script> proprietary attribute "onload" gambling.html:12:1 (gambling.Rd:6): Warning: <script> inserting "type" attribute gambling.html:17:1 (gambling.Rd:6): Warning: <table> lacks "summary" attribute pipe.html:4:1 (pipe.Rd:5): Warning: <link> inserting "type" attribute pipe.html:12:1 (pipe.Rd:5): Warning: <script> proprietary attribute "onload" pipe.html:12:1 (pipe.Rd:5): Warning: <script> inserting "type" attribute pipe.html:17:1 (pipe.Rd:5): Warning: <table> lacks "summary" attribute pipe.html:19:1 (pipe.Rd:5): Warning: <h2> attribute "id" has invalid value "+25+26gt+3B+25" pipe.html:35:1 (pipe.Rd:10): Warning: <table> lacks "summary" attribute pipe.html:36:14 (pipe.Rd:10): Warning: <code> attribute "id" has invalid value "+25+26gt+3B+25_:_lhs" pipe.html:40:14 (pipe.Rd:12): Warning: <code> attribute "id" has invalid value "+25+26gt+3B+25_:_rhs" self_eval.html:4:1 (self_eval.Rd:6): Warning: <link> inserting "type" attribute self_eval.html:12:1 (self_eval.Rd:6): Warning: <script> proprietary attribute "onload" self_eval.html:12:1 (self_eval.Rd:6): Warning: <script> inserting "type" attribute self_eval.html:17:1 (self_eval.Rd:6): Warning: <table> lacks "summary" attribute vicar_char.html:4:1 (vicar_char.Rd:6): Warning: <link> inserting "type" attribute vicar_char.html:12:1 (vicar_char.Rd:6): Warning: <script> proprietary attribute "onload" vicar_char.html:12:1 (vicar_char.Rd:6): Warning: <script> inserting "type" attribute vicar_char.html:17:1 (vicar_char.Rd:6): Warning: <table> lacks "summary" attribute`

0 errors ✔ \| 0 warnings ✔ \| 3 notes ✖
0 errors ✔ \| 0 warnings ✔ \| 2 notes ✖

*Author note on HTML validation problems:* Seems to be a problem on my
local MacOS system (which was not fixed by updating roxygen2), not
***Author note on HTML validation problems:*** Seems to be a problem on
my local MacOS system (which was not fixed by updating roxygen2), not
encountered on remote system checks.

#### Notes returned after running `devtools::check_win_devel()`:

- checking CRAN incoming feasibility ... [10s] NOTE
- checking CRAN incoming feasibility ... [11s] NOTE

Maintainer: 'Eduard Klapwijk
[et.klapwijk\@gmail.com](mailto:[email protected]){.email}'

New submission

- checking examples ... [26s] NOTE

Examples with CPU (user + system) or elapsed time \> 10s

user system elapsed

estim_diff 19.04 2.04 21.1
2 changes: 1 addition & 1 deletion man/estim_diff.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6a98a8a

Please sign in to comment.