Fix: atom-racer does not need to create temporary files #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atom-racer creates temporary files to provide completion even for unsafed content. This results in a lot of writes to the disk and is unnecessary. The racer command allows to pass a subsitute file whose content will be used instead of the file completion is invoked for (its location is used nevertheless). Instead of specifying a real substitute file '-' is passed and the contents are read from stdin. This also removes the 'temp' dependency.
|
Love this. Hope it can be merged. |
|
why isn't this merged yet? |
|
merged into racer-plus package here https://github.com/Xaeroxe/atom-racer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atom-racer creates temporary files to provide completion even for unsafed content.
This results in a lot of writes to the disk and is unnecessary. The racer command allows to
pass a subsitute file whose content will be used instead of the file completion is invoked for (its location is used nevertheless).
Instead of specifying a real substitute file '-' is passed and the contents are read from stdin.
This also removes the 'temp' dependency.