-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No leading zero on versions #44
Conversation
WalkthroughThe pull request modifies the versioning documentation and the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
versioning/README.md
(1 hunks)versioning/bump_version.sh
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
versioning/README.md
[uncategorized] ~14-~14: Loose punctuation mark.
Context: ...t as plain text. - bump_version.sh
: A script to increment the version based...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~15-~15: Loose punctuation mark.
Context: ... and release sequence. - README.md
: Documentation for the versioning proces...
(UNLIKELY_OPENING_PUNCTUATION)
🔇 Additional comments (3)
versioning/bump_version.sh (2)
27-27
: LGTM! Sequence number handling simplified correctly.
The changes properly implement:
- Direct sequence number increment without leading zeros
- Clean reset to 1 for new months
Also applies to: 29-29
32-32
: LGTM! Version string construction is correct.
The new version string construction properly implements the format year.month.sequential_number
without leading zeros.
versioning/README.md (1)
8-10
: LGTM! Version examples accurately reflect the new format.
The examples clearly demonstrate the new versioning scheme without leading zeros.
Summary by CodeRabbit
Documentation
year.month.sequential_number
.Chores