-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESPHome Version sensor #69
Conversation
And renames the TX Firmware, which resolves #66
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml (1)
170-173
: Consider adding entity category for consistency.For consistency with the
tx_fw_version
sensor, consider adding theentity_category: diagnostic
attribute to the ESPHome version sensor as well, since both are diagnostic version information.- id: esphome_fw_version platform: version name: "ESPHome Version" + entity_category: diagnostic
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml
(1 hunks)
🔇 Additional comments (2)
ESPHome/TX-Ultimate-Easy-ESPHome_core.yaml (2)
170-173
: LGTM! Well-implemented ESPHome version sensor.
The implementation correctly uses the built-in version platform to expose the ESPHome version information. The naming is clear and follows good practices.
175-175
: LGTM! Clear and descriptive firmware version naming.
The rename from "Firmware version" to "TX Ultimate Easy Firmware Version" improves clarity by explicitly distinguishing it from the ESPHome version. This change aligns well with issue #66.
And renames the TX Firmware, which resolves #66
Summary by CodeRabbit
New Features
Improvements