Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: Try sending New Relic traces to a place they'll be thrown out #48

Merged
merged 1 commit into from
Jun 25, 2024
Merged

temp: Try sending New Relic traces to a place they'll be thrown out #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions playbooks/roles/edxapp/templates/edx/app/edxapp/lms.sh.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ fi


{% if COMMON_ENVIRONMENT == "stage" or COMMON_DEPLOYMENT == "edge" %}
# Another attempt at a temporary workaround for trace concatenation in Datadog.
# Testing a temporary workaround for trace concatenation in Datadog.
# (Maybe this will keep NR trace instrumentation in place, but not cost us anything,
# because no data will be shipped to NR.)
# because this free-tier NR account will throw away most data.)
# See https://github.com/edx/edx-arch-experiments/issues/692
export NEW_RELIC_LICENSE_KEY="xxx"
export NEW_RELIC_LICENSE_KEY="{{ EDXAPP_NEWRELIC_LICENSE_TEST_FREE }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does New Relic use an API key alone to determine where to send the data? It needs no other matching id (e.g. account, etc.)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, yeah!

{% else %}
export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
{% endif %}
Expand Down
Loading