Skip to content

Commit

Permalink
build: Upgrade to Node 20, Removed Node 18 support (#50)
Browse files Browse the repository at this point in the history
* build: Upgrade to Node 20

* test: Remove support for Node 18
  • Loading branch information
BilalQamar95 authored Nov 4, 2024
1 parent c056a6c commit b837a8b
Show file tree
Hide file tree
Showing 4 changed files with 1,335 additions and 1,062 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node: [18, 20]
continue-on-error: ${{ matrix.node == 20 }}

steps:
- name: Checkout
Expand All @@ -22,7 +18,7 @@ jobs:
- name: Setup Nodejs
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version-file: '.nvmrc'
- name: Install dependencies
run: npm ci
- name: Lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ on:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfile-check.yml@master
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
Loading

0 comments on commit b837a8b

Please sign in to comment.