chore: fix script + test #1756
Merged
chore: fix script + test #1756
+40
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebygrace
force-pushed
the
katebygrace/fix-secrets-manager-script
branch
from
d5feabf to
bb30682
Compare
| --key_path $WORKSPACE/analytics-secure/$KEY_PATH \ | ||
| --passphrase_path $WORKSPACE/analytics-secure/$PASSPHRASE_PATH \ | ||
| --user $USER \ | ||
| --user 'SNOWPIPE' \ |
There was a problem hiding this comment.
Do we need to do this ?
There was a problem hiding this comment.
nah, but we arent going to call the extra_vars unless we really need to, so i replaced all of the vars
| --schema $SCHEMA \ | ||
| --account $ACCOUNT \ | ||
| --account 'edx.us-east-1' \ |
There was a problem hiding this comment.
Same as the user, I think we can leave that as is.
|
add a comment on how to call it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR