Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #273497-Layout issue with numbered lists #460

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Refs #273497-Layout issue with numbered lists #460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa22506
Refs #273497-Layout issue with numbered lists
tedw87 Sep 17, 2024
6e135bc
update value of ordered list padding
tedw87 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions theme/themes/eea/elements/list.overrides
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ ul.ui.list li:before {
font-size: @bulletSize;
}

/* Ordered list */

ol.ui.list,
.ui.ordered.list {
padding-left: @orderedDistance;
}

// Third layer margin fix
.ui.ordered.list .list .list > .item:before,
.ui.ordered.list .list .list > li:before {
Expand Down
14 changes: 5 additions & 9 deletions theme/themes/eea/elements/list.variables
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@
@linkListItemHoverColor: @hoveredTextColor;
@linkListItemDownColor: @pressedTextColor;
@linkListItemActiveColor: @selectedTextColor;
@linkListTransition:
@defaultDuration color @defaultEasing
;
@linkListTransition: @defaultDuration color @defaultEasing;

/* Inverted Link List */
@invertedLinkListItemColor: @invertedUnselectedTextColor;
Expand All @@ -129,8 +127,7 @@
@selectionListTransition:
@defaultDuration color @defaultEasing,
@defaultDuration padding-left @defaultEasing,
@defaultDuration background-color @defaultEasing
;
@defaultDuration background-color @defaultEasing;

/* Selection List States */
@selectionListBackground: transparent;
Expand Down Expand Up @@ -158,8 +155,7 @@
@animatedListTransition:
@animatedDuration color @defaultEasing @animatedDelay,
@animatedDuration padding-left @defaultEasing @animatedDelay,
@animatedDuration background-color @defaultEasing @animatedDelay
;
@animatedDuration background-color @defaultEasing @animatedDelay;
@animatedListIndent: 1em;

/* Bulleted */
Expand All @@ -181,12 +177,13 @@

/* Ordered List */
@orderedCountName: ordered;
@orderedCountContent: counters(ordered, ".") " ";
@orderedCountContent: counters(ordered, '.') ' ';
@orderedCountColor: inherit;
@orderedCountDistance: 1.25rem;
@orderedCountOpacity: 1;
@orderedCountTextAlign: right;
@orderedCountVerticalAlign: middle;
@orderedDistance: @rem-space-5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedw87 set value of @orderedDistance: @bulletDistance;
This way is that variable is different this value will take that value as
the right value to set for the padding.


@orderedChildCountDistance: 1em;
@orderedChildCountOffset: -2em;
Expand Down Expand Up @@ -232,4 +229,3 @@
@veryRelaxedChildItemVerticalPadding: @relative4px;
@veryRelaxedHeaderMargin: 0.5rem;
@veryRelaxedHorizontalPadding: 1.5rem;

Loading