Skip to content

Commit

Permalink
fixed bug in get_homologues.pl which meant pan genome was overestimat…
Browse files Browse the repository at this point in the history
…ed with -c
  • Loading branch information
eead-csic-compbio committed Feb 3, 2016
1 parent 8c714dd commit 5a72e59
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,4 @@
25012016: fixed bug in _cluster_makeHomolog.pl,_cluster_makeInparalog.pl,_cluster_makeOrtholog.pl reported by Maliha Aziz, which did not affect results, but produce them slower
01022016: updated download_genomes_ncbi.pl and sample_genome_list.txt to fit current NCBI repositories, and manual
01022016: removed estimate_RAM from get_homologues.pl, as RAM consumption has been reduced
03022016: fixed bug in get_homologues.pl which meant pan genome was overestimated with -c; EST not affected, thanks Joaquim Martins Jr!
7 changes: 3 additions & 4 deletions get_homologues.pl
Original file line number Diff line number Diff line change
Expand Up @@ -1719,7 +1719,6 @@
$LSE_reference = cluster_lineage_expansions($ref_inparalogues);
}


for($t=1;$t<$n_of_taxa;$t++)
{
$coregenome[$s][$t] = 0;
Expand Down Expand Up @@ -1835,7 +1834,7 @@
my $ref_homol = makeHomolog($saveRAM,$tmptaxa[$t],$tmptaxa[$t2],$evalue_cutoff,
$MIN_PERSEQID_HOM,$MIN_COVERAGE_HOM,$redo_orth);

foreach $gene ($gindex{$tmptaxa[$t]}[0] .. $gindex{$tmptaxa[0]}[1])
foreach $gene ($gindex{$tmptaxa[$t]}[0] .. $gindex{$tmptaxa[$t]}[1])
{
if($ref_homol->{$gene}){ $n_of_homs_in_genomes{$gene}++; }
}
Expand All @@ -1858,13 +1857,13 @@
}

# update pan total
foreach $gene ($gindex{$tmptaxa[$t]}[0] .. $gindex{$tmptaxa[0]}[1])
foreach $gene ($gindex{$tmptaxa[$t]}[0] .. $gindex{$tmptaxa[$t]}[1])
{
next if($n_of_homs_in_genomes{$gene} || $inparalogues{$gene});
$pangenome[$s][$t]++;
}

print "# adding $tmptaxa[$t]: core=$coregenome[$s][$t] pan=$pangenome[$s][$t]\n";
print "# adding $tmptaxa[$t]: core=$coregenome[$s][$t] pan=$pangenome[$s][$t]\n";
}
}

Expand Down

0 comments on commit 5a72e59

Please sign in to comment.