Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajmal changes #424

Merged
merged 15 commits into from
Nov 14, 2024
Merged

Ajmal changes #424

merged 15 commits into from
Nov 14, 2024

Conversation

ajmalroshan123
Copy link
Collaborator

Feature description

Implemented stone details too in jewellery Invoice when selecting item if it had stone.
Refacted the existing code.
Metal Ledger created against Stock Reconciliation (Opening Stock) distiguished as Opening Stock in Metal Ledger.
Implemented Option to set desired board rate in Stock Reconciliation for Opening Stock.
Fixed the existing errors.

Solution description

-> Needed to implement the Stone details in Jewellery Invoice when Item is selected and also set the discount for each stone and calculations should happen based on it .
-> When creating the Opening Stock it should show as opening stock in metal ledger.
-> Implemented Option to set desired board rate in Stock Reconciliation for Opening Stock.
-> Refactored the exsisting code .
-> In Purchase Receipt and Metal Ledger.

Output screenshots (optional)

image
image
image
image
image
image
image
image

Completed task

-> task -id's
[TASK-2024-00802]
[TASK-2024-01005]
[TASK-2024-01004]

Is there any existing behavior change of other features due to this code change?

yes

Was this feature tested on the browsers?

  • Chrome

aumms/hooks.py Outdated
Comment on lines 81 to 87
after_migrate = [
'aumms.setup.setup_aumms_defaults',
'aumms.aumms.utils.increase_precision'
'aumms.aumms.utils.increase_precision',
'aumms.setup.after_install'
]

after_migrate = "aumms.setup.after_migrate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this one

aumms/hooks.py Outdated
Comment on lines 106 to 115
"dt":"Workflow",
"filters":[["name","in",["Feasibility check"]]]
"filters":[["name","in",["Feasibility check", "Touch Validation Workflow", "Purchase Receipt Workflow","Hallmark Request Workflow"]]]
},
{
"dt":"Workflow Action Master",
"filters":[["name","in",["Submit for Feasibility check", "Approve", "Reject", "Submit", "Cancel"]]]
"filters":[["name","in",["Send for Hallmarking", "Hallmark Items Return", "Submit for Feasibility check", "Approve", "Reject", "Submit", "Cancel", "Review"]]]
},
{
"dt":"Workflow State",
"filters":[["name","in",["Draft", "Submitted for feasibility", "Feasible", "Not Feasible", "Submitted", "Cancelled"]]]
"filters":[["name","in",["Draft", "Submitted", "Sent for Hallmarking", "Send for Hallmarking", "Items Hallmarked", "Submitted for feasibility", "Feasible", "Not Feasible", "Submitted", "Cancelled", "Manager Approved", "Manager Rejected", "Director Approved", "Director Rejected", "Sent to Director", "Sent to Manager"]]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need these

@MhmdSinanKT MhmdSinanKT merged commit 2b7bc27 into develop Nov 14, 2024
1 check failed
@MhmdSinanKT MhmdSinanKT deleted the ajmal-changes branch November 14, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants