-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajmal changes #424
Merged
Merged
Ajmal changes #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of metal ledger
MhmdSinanKT
requested changes
Nov 11, 2024
aumms/hooks.py
Outdated
Comment on lines
81
to
87
after_migrate = [ | ||
'aumms.setup.setup_aumms_defaults', | ||
'aumms.aumms.utils.increase_precision' | ||
'aumms.aumms.utils.increase_precision', | ||
'aumms.setup.after_install' | ||
] | ||
|
||
after_migrate = "aumms.setup.after_migrate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this one
aumms/hooks.py
Outdated
Comment on lines
106
to
115
"dt":"Workflow", | ||
"filters":[["name","in",["Feasibility check"]]] | ||
"filters":[["name","in",["Feasibility check", "Touch Validation Workflow", "Purchase Receipt Workflow","Hallmark Request Workflow"]]] | ||
}, | ||
{ | ||
"dt":"Workflow Action Master", | ||
"filters":[["name","in",["Submit for Feasibility check", "Approve", "Reject", "Submit", "Cancel"]]] | ||
"filters":[["name","in",["Send for Hallmarking", "Hallmark Items Return", "Submit for Feasibility check", "Approve", "Reject", "Submit", "Cancel", "Review"]]] | ||
}, | ||
{ | ||
"dt":"Workflow State", | ||
"filters":[["name","in",["Draft", "Submitted for feasibility", "Feasible", "Not Feasible", "Submitted", "Cancelled"]]] | ||
"filters":[["name","in",["Draft", "Submitted", "Sent for Hallmarking", "Send for Hallmarking", "Items Hallmarked", "Submitted for feasibility", "Feasible", "Not Feasible", "Submitted", "Cancelled", "Manager Approved", "Manager Rejected", "Director Approved", "Director Rejected", "Sent to Director", "Sent to Manager"]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need these
MhmdSinanKT
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature description
Implemented stone details too in jewellery Invoice when selecting item if it had stone.
Refacted the existing code.
Metal Ledger created against Stock Reconciliation (Opening Stock) distiguished as Opening Stock in Metal Ledger.
Implemented Option to set desired board rate in Stock Reconciliation for Opening Stock.
Fixed the existing errors.
Solution description
-> Needed to implement the Stone details in Jewellery Invoice when Item is selected and also set the discount for each stone and calculations should happen based on it .
-> When creating the Opening Stock it should show as opening stock in metal ledger.
-> Implemented Option to set desired board rate in Stock Reconciliation for Opening Stock.
-> Refactored the exsisting code .
-> In Purchase Receipt and Metal Ledger.
Output screenshots (optional)
Completed task
-> task -id's
[TASK-2024-00802]
[TASK-2024-01005]
[TASK-2024-01004]
Is there any existing behavior change of other features due to this code change?
yes
Was this feature tested on the browsers?