resolver.nameservers may need to be a list of strings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this might instead not be an issue I've only got in my setup, but (1) this line broke my setup for me (with the regrettably non-helpful error message "DNS timeout", leading to some hours of debugging), (2) in other places in this hook, it is handled as a list of strings, suggesting that's indeed what it should be (but the lack of open issues about this and the age of the line of code is confusing - although possibly #30 may be related).
Turning it into a list of strings fixed my problems.
Feel free to accept or reject as you see fit - you're a much better judge if this is just my setup's problem and would break things for other people, or if this is a fix of a general problem! :)