Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap page that allows for EFX/BNB and EFX/NFX swapping locally #191

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

MiggySmallz
Copy link
Contributor

The page just uses two iframes, 1 for PancakeSwap and 1 for DefiBox to allow members to swap directly on the DAO website. Let me know if this might be a suitable solution for allowing swapping on the site.

This resolves #170 and #171

@jeisses
Copy link
Member

jeisses commented Mar 3, 2023

Hi Miguel, thanks for the PR!
This looks pretty good actually (the iFrame solution). Functionality wise it needs some improvements:

  • The Defibox iFrame does not auto-select the correct pair form me (it fills EOS but not token to swap to).
  • In Chrome the iFrames do not work for me. I'm getting a permission error for writing to local storage (see screenshot, this does not happen in Firefox).
    image
    This could be related to being on localhost over http, does it work for you on Chrome?
  • I think the UI for the switcher element can be more clear, I don't mind to make take a stab at this to make it more clear :)
  • This PR combines the Socials tab PR, on which I also have a few questions. So it's not ready for merge straight away

@djstrikanova
Copy link
Contributor

I don't think Defibox has the GET requests set up for pairs to be pre-selected to begin with. I could ask them to add that type of functionality though. It would be nice for people to just click buttons to switch between EOS/EFX and EFX/NFX.

It works for me on Brave, Chrome and Firefox.

Agree with Jesse on the buttons being kinda clunky, but that's a minor detail.

@jeisses jeisses merged commit 41c2705 into effectai:main Mar 8, 2023
@jeisses
Copy link
Member

jeisses commented Mar 8, 2023

The PR closed as the commits were part of #190 ; but some improvements still need to happen before we can put the page in the navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create swap widget in the DAO for EFX
3 participants