Fix timing issue in RecordCoverImageTest. (vufind-org#4127)

Co-authored-by: Thomas Wagener <[email protected]>
effective-webwork · Dec 3, 2024 · 6f1f43e · 6f1f43e
1 parent dc17ec1
commit 6f1f43e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 11 deletions.
diff --git a/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/RecordCoverImageTest.php b/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/RecordCoverImageTest.php
@@ -167,7 +167,7 @@ public function testCoverLoading(
         $this->waitForPageLoad($page);
         $session->wait(
             $this->getDefaultTimeout(),
-            'document.querySelector("img.recordcover").complete && document.querySelector("img.recordcover").src'
+            'document.querySelector("img.recordcover").dataset.loaded !== undefined'
         );
         // Verify the expected backlink (or lack thereof):
         $backlinkSelector = 'p.cover-source';

diff --git a/themes/bootstrap3/js/covers.js b/themes/bootstrap3/js/covers.js
@@ -85,11 +85,14 @@ VuFind.register('covers', function covers() {
   function checkLoaded(container) {
     container.querySelectorAll('.recordcover').forEach(
       (img) => {
-        img.addEventListener('load', () => {
-          if (img.getBoundingClientRect().width < 2) {
-            img.classList.add('hidden');
-          }
-        });
+        if (img.dataset.loaded === undefined) {
+          img.addEventListener('load', () => {
+            if (img.getBoundingClientRect().width < 2) {
+              img.classList.add('hidden');
+            }
+            img.dataset.loaded = 'true';
+          });
+        }
       }
     );
   }

diff --git a/themes/bootstrap5/js/covers.js b/themes/bootstrap5/js/covers.js
@@ -85,11 +85,14 @@ VuFind.register('covers', function covers() {
   function checkLoaded(container) {
     container.querySelectorAll('.recordcover').forEach(
       (img) => {
-        img.addEventListener('load', () => {
-          if (img.getBoundingClientRect().width < 2) {
-            img.classList.add('hidden');
-          }
-        });
+        if (img.dataset.loaded === undefined) {
+          img.addEventListener('load', () => {
+            if (img.getBoundingClientRect().width < 2) {
+              img.classList.add('hidden');
+            }
+            img.dataset.loaded = 'true';
+          });
+        }
       }
     );
   }