Merge pull request vufind-org#4131 from demiankatz/image-dimensions-i…

…n-test Include dimension data in image test failure message.
effective-webwork · Dec 4, 2024 · b9ff53e · b9ff53e
2 parents beb7b8d + 49cdaa6
commit b9ff53e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/RecordCoverImageTest.php b/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/RecordCoverImageTest.php
@@ -165,9 +165,10 @@ public function testCoverLoading(
         $session->visit($url);
         $page = $session->getPage();
         $this->waitForPageLoad($page);
+        $coverSelector = 'img.recordcover';
         $session->wait(
             $this->getDefaultTimeout(),
-            'document.querySelector("img.recordcover").dataset.loaded !== undefined'
+            "document.querySelector('$coverSelector').dataset.loaded !== undefined"
         );
         // Verify the expected backlink (or lack thereof):
         $backlinkSelector = 'p.cover-source';
@@ -185,10 +186,13 @@ public function testCoverLoading(
         $expectedClasses = 'recordcover'
             . ($ajaxcovers ? ' ajax' : '')
             . (empty($noCoverAvailableImage) ? ' hidden' : '');
-        $coverImage = $this->findCss($page, 'img.recordcover');
+        $coverImage = $this->findCss($page, $coverSelector);
+        $width = $session->evaluateScript("document.querySelector('$coverSelector').getBoundingClientRect().width");
+        $height = $session->evaluateScript("document.querySelector('$coverSelector').getBoundingClientRect().height");
         $this->assertEquals(
             $expectedClasses,
-            $coverImage?->getAttribute('class')
+            $coverImage?->getAttribute('class'),
+            "Unexpected classes on image of dimensions $width x $height"
         );
 
         // Verify the expected image URL: