removed scope from config; added pageClientStarted #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeysova
reviewed
Sep 15, 2024
| @@ -6,10 +6,8 @@ declare global { | |||
| interface PageContext { | |||
| config: { | |||
| pageStarted?: EventCallable<{ params: Record<string, string>; data: unknown }>; | |||
| pageClientStarted?: EventCallable<void>; | |||
There was a problem hiding this comment.
What do you think to make universal interface with pageStarted, pageClientStarted, and possible createServerStarted?
Suggested change
| pageClientStarted?: EventCallable<void>; | |
| pageClientStarted?: EventCallable<{ params: Record<string, string>; data: unknown }>; |
sergeysova
reviewed
Oct 10, 2024
| @@ -32,6 +32,7 @@ | |||
| "node": ">=18.6.0" | |||
| }, | |||
| "dependencies": { | |||
| "@effector/next": "^0.7.0", | |||
There was a problem hiding this comment.
Why @effector/next is required for vike?
There was a problem hiding this comment.
this is the same situation as in nextjs
we have to have 1 scope for an app and provide partial hydration of values
sergeysova
reviewed
Dec 9, 2024
| onClientStarted(); | ||
| clientStartedRef.current = true; | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
Suggested change
| }, []); | |
| }, [onClientStarted]); |
It is required, when we can switch from page without .pageClientStarted to another with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.