Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default arguments of benchmarks #718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marvinborner
Copy link
Member

While working on effekt-lang/effekt-plots#10, I've realized that the default arguments for the benchmarks are not working as expected (mostly because of formatting issues that we somehow missed).

Also, we need to consider a different argument for effect_handlers_bench/resume_nontail because the JS backend can't handle 10000 (for now I've set it to 1000)

@b-studios
Copy link
Collaborator

Right now I think it would be great to have the same numbers for JS and LLVM if possible. This way we could compare much better. If the numbers are the "standard" number (like from effect-handlers-bench), even better.

@marvinborner
Copy link
Member Author

In the attached plots PR we now also support the are_we_fast_yet JS reference benchmarks. I think we should only merge this if we settled on default arguments here -- notably the ones that overflow in JS.

Otherwise we could also remove all the lines that are not relevant for are_we_fast_yet. This would allow us to compare this data and would not cause overflows since its default args are quite small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants