-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valgrind fails in CI #790
base: master
Are you sure you want to change the base?
Valgrind fails in CI #790
Conversation
9e947dd
to
af99d67
Compare
cf2c1d9
to
5c19040
Compare
I did some investigating on these valgrind errors and found that it was complaining about "uninitialized value was created by a heap allocation" when using bytearrays. If we just initialize the allocated memory to 0 the valgrind errors disappear |
We were accessing uninitialized memory whenever using bytearrays which causes valgrind to complain. Now that memory is just initialized to 0
d31dbb4
to
0a13886
Compare
I'm all for using |
That would be great! Is there any performance implications of doing that? |
I'm confused, this shouldn't be a problem, right? Why are we reading from the bytearray when it's not initialized yet (especially in all IO tests)? If I remember correctly, we've discussed calloc-ing before and decided against it(?) I think the performance implications could be significant, since bytearrays could be used for loading multiple gigabytes of data etc. |
It is good to know that initializing the array would fix it, but we should not actually initialize them to zero every time. Rather, we should find the underlying out-of-bounds access. I can not reproduce those errors locally, but @mattisboeckle since you can, please take a look. |
No description provided.