-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the git reset exercise #298
base: master
Are you sure you want to change the base?
Improve the git reset exercise #298
Conversation
…oves files added to the staging area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial thought is that this is actually a valuable addition to the exercise, and illustrates a quite important point.
The only reason that I am reluctant to immediately approve this, is that the reset exercise is such a cornerstone of our training, and I at least usually run through it on the whiteboard, so I think I will want to do a test-run in front of a live audience before I commit.
I ran the exercise today with these new instructions, and it worked quite well. It does complicate the scenario a bit, but it also teaches more. or something like that. |
There is however a slight disadvantage with this mod in general. It directly addresses the fact that 9 & 10 are left untracked after the |
@Zleep-Dogg Sorry. I haven't forgotten about this PR. I am just still on the fence about the change. We have also been considering somehow adding |
@JKrag since it's over 2 years from last discussion, should we close this? |
Improve the git reset exercise to show that reset --hard actually removes files added to the staging area