Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local minor update to PR #370 #376

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Local minor update to PR #370 #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef188b5
Added configuration for git credentials in setup
TidosDK Aug 7, 2024
8bf583a
Fixed bug in bisect verify.sh
TidosDK Aug 7, 2024
a59cb94
Merge branch 'master' into master
JKrag Nov 4, 2024
913b575
Use pre-setup & post-setup as suggested in review
JKrag Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bisect/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
source ../utils/utils.sh

make-exercise-repo
pre-setup # Make exercise repo, and setup necessary.

echo '#! /usr/bin/env bash' > 'test.sh'
echo 'if [[ $(( $(find * | wc -l) + 10 )) -gt 32 ]] ;then' >> 'test.sh'
Expand All @@ -23,3 +23,4 @@ do
git commit -m $i
done

post-setup
4 changes: 2 additions & 2 deletions bisect/verify.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#! /usr/bin/env sh

cd exercise
if [[ "$(git log -1 --format='%s' refs/bisect/bad -- )" = '22' ]] ; then
cd exercise || exit
if [ "$(git log -1 --format='%s' refs/bisect/bad -- )" = '22' ] ; then
echo "You managed to find the bad commit with bisect"
else
echo "You have still stuff to do"
Expand Down
Loading