Fix service registry clustering #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2022 18:30
RegistryParams is no longer a raw map[string]interface{}
Instead, it is a struct with raw values that are json-capable.
This was failing silently in previous builds. In the release prior to this change, it was failing *loudly*. Now it's no longer failing.
For some reason, the somewhat aged ccv3 client that is in our vendor bundle is unable to `UpdateApplication` if given an application object retrieved from the API. The error presented is "Unknown field(s): relationships" and is being generated on the capi side of the equation. We've worked around this by creating a temporary copy of the app object without its relationships collection and passing THAT temp object to the update call. It appears that this likely also affects update_config_server workflow, and we should double-check that.
|
@TheDigitalEagle Before merging this, please try updating a running config-server instance and let me know if you'd like me to apply my fix to the update_config_server_instance workflow. |
`utilities.SafeApp(ccv3.Application) ccv3.Application`
This is to avoid doing partial service-registry creations/updates in the event that we receive an invalid (<1) desired node count.
We confirmed that the config server update workflow is affected by the same issue that utterly plagued the registry server update workflow. So we put in the same fix.
In an attempt to get registry server peering working correclty, we're now presenting the internal connection info for each registry server process instance as a peer. In a perfect world, we'd be doing per-process-instance peer configuration, but we've yet to find a way to do this.
This appears to be the only viable way to provide information to the process instances that can be used to derive a working service registry peering configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were previously two issues with registry server:
countconfiguration wasn't being honored. This was due to a dangling bit of logic in the provision/update workflows around scaling the service-registry app. This has been rectified.relationshipsfield that is part of that object. I've worked around this in update_registry_server_instance by creating a temp copy of the app object without relationships and passing that instead.