-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat : added user mapping for multiple boundaries with common parent #1005
Conversation
WalkthroughWalkthroughThe recent changes enhance the configuration and utility mappings within the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Server as Server (config)
participant Utils as Utils (campaignMappingUtils)
User ->> Server: Request configuration
Server -->> User: Provide configuration with mapUserViaCommonParent
User ->> Utils: Request to enrich boundary codes
Utils ->> Utils: trimBoundaryCodes()
Utils ->> Utils: getAllBoundaries()
Utils ->> Utils: findPath()
Utils ->> Utils: findCommonParent()
Utils ->> Utils: mapBoundaryCodes()
Utils -->> User: Return enriched boundary codes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- utilities/project-factory/src/server/config/index.ts (2 hunks)
- utilities/project-factory/src/server/utils/campaignMappingUtils.ts (3 hunks)
Files skipped from review due to trivial changes (1)
- utilities/project-factory/src/server/config/index.ts
Additional comments not posted (6)
utilities/project-factory/src/server/utils/campaignMappingUtils.ts (6)
39-48
: LGTM!The
trimBoundaryCodes
function correctly trims whitespace from boundary codes and processes child boundaries recursively.
50-67
: LGTM!The
getAllBoundaries
function correctly retrieves boundaries and trims their codes.
69-79
: LGTM!The
findPath
function correctly finds the path to a given boundary code recursively.
81-103
: LGTM!The
findCommonParent
function correctly finds the common parent for multiple boundary codes.
105-135
: LGTM!The
mapBoundaryCodes
function correctly maps boundary codes to resources, considering common parents if applicable.
Line range hint
136-156
: LGTM!The
enrichBoundaryCodes
function correctly enriches boundary codes for resources.
No description provided.