BUGFIX/HCMPRE-1730: Fixes pagination in mapping table

[nabeelmd-eGov]

• BUGFIX/HCMPRE-1730 & HCMPRE-1731
• fixes
• BUGFIX/HCMPRE_1730: Fix pagination

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

• New Features

  • Introduced pagination with customizable rows per page in the data upload component.
  • Added filtering functionality based on active status for better data management.

• Bug Fixes

  • Improved clarity of messages displayed when no results are found after filtering.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies the UploadDataMapping.js component in the campaign manager module, focusing on enhancing state management and rendering logic for pagination and filtering. The changes introduce a new state variable rowsPerPage to control the number of rows displayed per page, update the reducer function to support filtering by active status, and improve the rendering of data tables and no-results scenarios.

Changes

File	Change Summary
health/micro-ui/.../UploadDataMapping.js	- Added rowsPerPage state variable initialized to 5 - Updated reducer to support FILTER_BY_ACTIVE action - Modified pagination and filtering logic - Enhanced NoResultsFound component text rendering

Possibly related PRs

• BUGFIX/HCMPRE-1243: added check for empty upload  #2056: Adds check for empty uploads in UploadDataMapping.js
• BUGFIX/HCMPRE-1730 & HCMPRE-1731 #2070: Improves rendering logic for "No Results Found" message

Suggested reviewers

• nipunarora-eGov
• jagankumar-egov

Poem

🐰 Hop, hop, through data's maze,
Pagination dances, filtering plays,
Rows per page, a rabbit's delight,
Filtering active with algorithmic might,
Code hops smoothly, no results in sight! 🥕

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 8

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1071972 and 77e618a.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMapping.js (9 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMapping.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMapping.js

[error] 127-137: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

---

[error] 454-454: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 424-424: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

---

[error] 627-627: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)

---

[error] 628-628: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

🔇 Additional comments (4)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadDataMapping.js (4)

140-140: Ensure accurate total row count for filtered data.
While totalRows is set further down, confirm that tempActive (set above) matches the same filter logic for both display and totals to avoid discrepancies between displayed rows and row count.

---

351-351: Synchronize rowsPerPage sources.
Since you’re dispatching SET_ROWS_PER_PAGE to update the reducer’s rowsPerPage, confirm that you actually consume state.rowsPerPage for pagination. If the local rowsPerPage and the reducer’s rowsPerPage diverge, pagination may behave unexpectedly.

---

649-649: Check boundary label text.
Ensure “CHOOSE_BOUNDARY” is the correct label, matching your business logic. If you plan more descriptive text (e.g., “Select Boundary”), update the translation key accordingly.

---

127-137: 🧹 Nitpick (assertive)

Wrap local variable declaration in a block to conform to best practices.
Some linters warn against declaring variables directly inside switch cases, as scoping could become ambiguous. Consider placing const tempActive = ...; inside a block to clearly scope it under the FILTER_BY_ACTIVE case.

 case "FILTER_BY_ACTIVE": {
-  const tempActive = action.payload?.filter
+  {
+    const tempActive = action.payload?.filter
     ? getPageData(...)
     : ...
   return {
     ...
   };
 }

Likely invalid or redundant comment.

🧰 Tools

🪛 Biome (1.9.4)

[error] 127-137: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Unsafe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)