-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX/SN-352 : making account name to max 60 length #2086
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the sign-up configuration file, specifically adding validation and informational properties to the account name input field. The changes include setting a maximum length of 60 characters for the account name and introducing an information message tooltip reference, which aims to enhance user input validation and provide additional guidance during the sign-up process. Changes
Suggested Reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/SignUp/config.js
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/SignUp/config.js (1)
Pattern **/*.js
: check
🔇 Additional comments (2)
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/SignUp/config.js (2)
32-32
: Good enhancement for input validation.
Adding a maximum length of 60 ensures that overly long names are restricted, which can prevent potential UI overflow or database issues. The limit seems reasonable for typical user account names.
32-32
: Informative tooltip is beneficial.
Providing infoMessage:"SANDBOX_SIGNUP_ACCOUNT_NAME_TOOLTIP"
helps guide the user. Verify that the tooltip text is sufficiently descriptive and localized if the application supports multiple languages.
@@ -29,6 +29,7 @@ export const SignUpConfig = [ | |||
validation: { | |||
required: true, | |||
pattern: /^[A-Za-z]+( [A-Za-z]+)*$/, | |||
maxLength: 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Consider allowing a broader character set if needed.
The regex pattern currently only allows letters and spaces. If users might have names with accents, apostrophes, hyphens, or other characters, consider adjusting the regex to support those characters as well.
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit