Feature/microadd #418
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| * @egovernments/services-pr-reviewer @kavi-egov @saiprakash-egov |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| ServiceMaps: | ||
| serviceName: plan-service | ||
| version: 1.0.0 | ||
| mappings: | ||
| - topic: save-plan | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: plan-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Plan | ||
| customJsonMapping: | ||
| indexMapping: {"Data":{}} | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
|
||
| - topic: update-plan | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: plan-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Plan | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
|
||
| - topic: bulk-update-plan | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: plan-index-v1 | ||
| type: general | ||
| id: $.id | ||
| isBulk: true | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Plans | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
Comment on lines
+33
to
+46
There was a problem hiding this comment. 💡 Codebase verification Bulk update operations lack essential safeguards Based on the verification, the bulk update configurations in the indexer files do not include rate limiting or batch size controls. This could potentially lead to performance issues or resource exhaustion during bulk operations. Key locations requiring safeguards:
Recommend adding:
🔗 Analysis chainVerify bulk update operation safeguards The bulk update configuration should include:
Let me search for any rate limiting or batch size configurations. Let me try another approach to search for configuration files that might contain bulk operation controls. Let me try one more search to look for any configuration files that might contain bulk operation settings. Let me check the content of these files to see if they contain any bulk operation controls. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for bulk operation configurations and safeguards
rg -A 5 "bulk-update|isBulk:\s*true"
Length of output: 19796 Script: #!/bin/bash
# Search for rate limiting or batch size configurations
rg -i "batch|rate|limit|size" egov-indexer/
Length of output: 45 Script: #!/bin/bash
# Look for configuration files and search for any bulk operation controls
fd -e yml -e yaml -e json -e properties -e conf | xargs cat 2>/dev/null | grep -i "batch\|bulk\|size\|limit\|rate"
Length of output: 102511 Script: #!/bin/bash
# Search for configuration files and any bulk operation settings
fd -e yml -e yaml -e properties -e conf -e json . | xargs grep -l "bulk\|batch" 2>/dev/null
Length of output: 300 Script: #!/bin/bash
# Check content of the identified files for bulk operation controls
cat egov-indexer/Plan-service-indexer.yml egov-indexer/census-service-indexer.yml egov-indexer/project-indexer.yml egov-indexer/project-staff-indexer.yml egov-indexer/project-task-indexer.yml egov-indexer/stock-indexer.yml | grep -A 5 -B 5 "bulk"
Length of output: 2227 🧰 Tools🪛 yamllint (1.35.1)[error] 42-42: syntax error: mapping values are not allowed here (syntax) |
||
|
|
||
| - topic: save-plan-facility | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: plan-facility-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.PlanFacility | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
|
||
| - topic: update-plan-facility | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: plan-facility-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.PlanFacility | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| ServiceMaps: | ||
| serviceName: census-service | ||
| version: 1.0.0 | ||
| mappings: | ||
| - topic: census-create-topic | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: census-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Census | ||
| customJsonMapping: | ||
| indexMapping: {"Data":{}} | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
|
||
| - topic: census-update-topic | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: census-index-v1 | ||
| type: general | ||
| id: $.id | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Census | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data | ||
|
|
||
| - topic: census-bulk-update-topic | ||
| configKey: INDEX | ||
| indexes: | ||
| - name: census-index-v1 | ||
| type: general | ||
| id: $.id | ||
| isBulk: true | ||
| timeStampField: $.auditDetails.createdTime | ||
| jsonPath: $.Census | ||
| customJsonMapping: | ||
| indexMapping: { "Data": { } } | ||
| fieldMapping: | ||
| - inJsonPath: $ | ||
| outJsonPath: $.Data |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix YAML syntax error in bulk update mapping
The
customJsonMappingkey has incorrect indentation.Apply this fix:
📝 Committable suggestion
🧰 Tools
🪛 yamllint (1.35.1)
[error] 42-42: syntax error: mapping values are not allowed here
(syntax)