Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created en_IN localisation for HCM Admin console v0.1 #116

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Shreya-egov
Copy link
Collaborator

@Shreya-egov Shreya-egov commented May 28, 2024

Summary by CodeRabbit

  • New Features
    • Introduced new localization messages for the administrative console, enhancing support for tasks such as setting targets, creating users, and managing facilities within specific boundaries.

@Shreya-egov Shreya-egov requested a review from a team as a code owner May 28, 2024 13:52
@Shreya-egov Shreya-egov requested review from GhanshyamRawat-eGov and removed request for a team May 28, 2024 13:52
Copy link

coderabbitai bot commented May 28, 2024

Warning

Rate limit exceeded

@Shreya-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 45 minutes and 41 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9e5b284 and cd47af6.

Walkthrough

The recent updates to the rainmaker-hcm-admin-schemas.json file in the localisation/HCM/HCM Admin Console/en_IN directory introduce a comprehensive set of new localization messages. These messages support various administrative console functionalities, including setting targets, creating users, and managing facilities within specific boundaries. This enhancement aims to improve the user experience by providing localized content for administrative tasks.

Changes

File Path Change Summary
localisation/HCM/HCM Admin Console/en_IN/... Added numerous localization messages for administrative functionalities such as setting targets, creating users, and managing facilities within specific boundaries.

Poem

In the console of HCM, so bright and new,
Localization messages for all to view.
Setting targets, creating users with ease,
Managing facilities, boundaries to please.
A world of admin tasks, now crystal clear,
With every message, we hold dear.
🌟🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jagankumar-egov jagankumar-egov changed the title Create en_IN Created en_IN localisation for HCM Admin console v0.1 Jun 5, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1)

1-1766: Perform a spell check on all message fields to ensure professionalism.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1906a5e and 82b750d.

Files selected for processing (2)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1 hunks)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1 hunks)
Files not summarized due to errors (1)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json: Error: Message exceeds token limit
Additional comments not posted (8)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (6)

10-13: Localization for "Setting targets" has been successfully added.


89-105: Localization for downloading and setting targets using Excel templates has been added comprehensively.


107-129: Detailed instructions for setting targets post-download have been added, enhancing user guidance.


137-159: Localization for handling common errors during target setting has been added, which should help in troubleshooting.


191-231: The added localization messages for managing facilities within specific boundaries are detailed and cover various scenarios, including error handling.


491-537: The localization for creating users within specific boundaries has been added. This includes detailed steps and error handling, which should greatly aid administrators.

localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (2)

1-1766: Ensure JSON structure is valid and consistent across all entries.


1-1766: Review all user-facing messages for clarity and consistency.

#!/bin/bash
# Description: Check for consistency in terminology and clarity in messages.

# Test: Search for inconsistent terminology usage. Expect: Consistent terminology across messages.
rg --type json --json 'message' localisation/HCM/HCM\ Admin\ Console/en_IN/rainmaker-campaignmanager.json | sort | uniq -c | sort -nr

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 82b750d and 9e5b284.

Files selected for processing (2)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1 hunks)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1 hunks)
Files not summarized due to errors (1)
  • localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json: Error: Message exceeds token limit
Additional comments not posted (4)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1)

1-914: The localization entries are well-formed and consistent with the required format. Ensure that all terms are correctly translated and culturally appropriate for the Indian English locale.

localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (3)

1-1802: The JSON structure is correctly formatted and all entries are consistent with the required keys for localization.


1-1802: All localization keys and messages are consistent and properly localized for the "en_IN" locale.


1-1802: The text quality across all messages is high, with no typographical errors detected.

Comment on lines +1 to +1802
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_CREATE_HIERARCHY",
"message": "Create Hierarchy",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_DELETE",
"message": "Delete",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_DOWLOAD_TEMPLATE",
"message": "Download Template",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_DOWNLOAD",
"message": "Download",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_DOWNLOAD_TEMPLATE",
"message": "Download Template",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_DRAG_DROP",
"message": "Drag and drop your filled excel sheet or ",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_HIERARCHY_DETAILS",
"message": "Hierarchy Details",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_HIERARCHY_NAME",
"message": "Hierarchy name",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_HIERARCHY_TYPE",
"message": "Select hierarchy type",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_LOC_BULK_UPLOAD_XLS",
"message": "Bulk Upload Boundaries",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UNABLE_TO_FIND_HIERARCHY_TYPE",
"message": "Create new hierarchy type",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UPLOAD_BOUNDARY",
"message": "Upload boundary",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UPLOAD_FACILITY",
"message": "Upload facility data",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UPLOAD_Facility",
"message": "Upload facility data",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UPLOAD_TARGET",
"message": "Upload target data",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
},
{
"code": "WBH_UPLOAD_USER",
"message": "Upload user data",
"module": "rainmaker-campaignmanager",
"locale": "en_IN"
}
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider conducting a cultural review of the messages to ensure all terms are appropriate and clear in the context of their use in the Indian English locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants