-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created en_IN localisation for HCM Admin console v0.1 #116
base: master
Are you sure you want to change the base?
Conversation
Warning Rate limit exceeded@Shreya-egov has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 45 minutes and 41 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1)
1-1766
: Perform a spell check on all message fields to ensure professionalism.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1 hunks)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1 hunks)
Files not summarized due to errors (1)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json: Error: Message exceeds token limit
Additional comments not posted (8)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (6)
10-13
: Localization for "Setting targets" has been successfully added.
89-105
: Localization for downloading and setting targets using Excel templates has been added comprehensively.
107-129
: Detailed instructions for setting targets post-download have been added, enhancing user guidance.
137-159
: Localization for handling common errors during target setting has been added, which should help in troubleshooting.
191-231
: The added localization messages for managing facilities within specific boundaries are detailed and cover various scenarios, including error handling.
491-537
: The localization for creating users within specific boundaries has been added. This includes detailed steps and error handling, which should greatly aid administrators.localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (2)
1-1766
: Ensure JSON structure is valid and consistent across all entries.
1-1766
: Review all user-facing messages for clarity and consistency.#!/bin/bash # Description: Check for consistency in terminology and clarity in messages. # Test: Search for inconsistent terminology usage. Expect: Consistent terminology across messages. rg --type json --json 'message' localisation/HCM/HCM\ Admin\ Console/en_IN/rainmaker-campaignmanager.json | sort | uniq -c | sort -nr
Updated releasekit with HCM 1.4 release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (1 hunks)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1 hunks)
Files not summarized due to errors (1)
- localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json: Error: Message exceeds token limit
Additional comments not posted (4)
localisation/HCM/HCM Admin Console/en_IN/rainmaker-hcm-admin-schemas.json (1)
1-914
: The localization entries are well-formed and consistent with the required format. Ensure that all terms are correctly translated and culturally appropriate for the Indian English locale.localisation/HCM/HCM Admin Console/en_IN/rainmaker-campaignmanager.json (3)
1-1802
: The JSON structure is correctly formatted and all entries are consistent with the required keys for localization.
1-1802
: All localization keys and messages are consistent and properly localized for the "en_IN" locale.
1-1802
: The text quality across all messages is high, with no typographical errors detected.
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_CREATE_HIERARCHY", | ||
"message": "Create Hierarchy", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_DELETE", | ||
"message": "Delete", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_DOWLOAD_TEMPLATE", | ||
"message": "Download Template", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_DOWNLOAD", | ||
"message": "Download", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_DOWNLOAD_TEMPLATE", | ||
"message": "Download Template", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_DRAG_DROP", | ||
"message": "Drag and drop your filled excel sheet or ", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_HIERARCHY_DETAILS", | ||
"message": "Hierarchy Details", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_HIERARCHY_NAME", | ||
"message": "Hierarchy name", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_HIERARCHY_TYPE", | ||
"message": "Select hierarchy type", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_LOC_BULK_UPLOAD_XLS", | ||
"message": "Bulk Upload Boundaries", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UNABLE_TO_FIND_HIERARCHY_TYPE", | ||
"message": "Create new hierarchy type", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UPLOAD_BOUNDARY", | ||
"message": "Upload boundary", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UPLOAD_FACILITY", | ||
"message": "Upload facility data", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UPLOAD_Facility", | ||
"message": "Upload facility data", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UPLOAD_TARGET", | ||
"message": "Upload target data", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
}, | ||
{ | ||
"code": "WBH_UPLOAD_USER", | ||
"message": "Upload user data", | ||
"module": "rainmaker-campaignmanager", | ||
"locale": "en_IN" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider conducting a cultural review of the messages to ensure all terms are appropriate and clear in the context of their use in the Indian English locale.
Summary by CodeRabbit