Fix schedule order via interval-rewrite rules #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
requested changes
Nov 22, 2024
| @@ -123,6 +123,6 @@ | |||
| (union new-expr loop) | |||
| (union new-loop-context (InLoop (Arg argI new-if-true-ctx) new-loop-outputs)) | |||
|
|
|||
| (delete (DoWhile inpW outW)) | |||
| (subsume (DoWhile inpW outW)) | |||
There was a problem hiding this comment.
Is this an unrelated change?
I had a weird bug with this this morning that we should investigate where nothing could be extracted
There was a problem hiding this comment.
I also had this in my previous PR. It just makes our rules more consistent (always use subsume rather than delete).
Your bug might be caused by the wrong schedule order that the other changes in this PR fix? I had a similar issue and that was actually the original motivation for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #680