fix: rm Acts detail header for stable interface #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In acts-project/acts#2617 the detail header will be removed.
wdconinc
temporarily deployed
to
github-pages
GitHub Actions
Inactive
osbornjd
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Looks fine to me. For a future PR we may consider just going ahead and implementing our own custom detector element (that has the exact same functionality as the current default), as this is how the alignment transforms are applied. I imagine it will inherit from DD4hepDetectorElement in our case
wdconinc
added a commit
that referenced
this pull request
Dec 23, 2023
### Briefly, what does this PR introduce? In acts-project/acts#2617 the detail header will be removed. ### What kind of change does this PR introduce? - [x] Bug fix (issue: Acts v31 compatibility) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
In acts-project/acts#2617 the detail header will be removed.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.