Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd4hep: apply upstream fix for CylindricalGridPhiZ #688

Merged
merged 1 commit into from
Nov 25, 2024
Merged

dd4hep: apply upstream fix for CylindricalGridPhiZ #688

merged 1 commit into from
Nov 25, 2024

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 25, 2024

@ybedfer
Copy link
Contributor

ybedfer commented Nov 25, 2024 •
edited
Loading

  • The fix is required for my 2D-strip-segmentation of CyMBal to work properly. Which segmentation is implemented in yet to be merged 2D-strip-MPGDs branches of epic and eicrecon. PR foreseen.
  • It must not have any impact otherwise, since CylindricalGridPhiZ is not used anywhere else. Except in exploratory work by Shujie Li @shujieli on a cylindrical SVT.
  • Is there something I am expected to do for the PR to proceed?

ybedfer
ybedfer approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@ybedfer ybedfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The fix is required for my 2D-strip-segmentation of CyMBal to work properly. Which segmentation is implemented in yet to be merged 2D-strip-MPGDs branches of epic and eicrecon. PR foreseen.
  • It must not have any impact otherwise, since CylindricalGridPhiZ is not used anywhere else. Except in exploratory work by Shujie Li @shujieli on a cylindrical SVT.

@veprbl veprbl merged commit 23c962e into develop Nov 25, 2024
2 checks passed
@veprbl veprbl deleted the pr/dd4hep_CylindricalGridPhiZ_fix branch November 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybedfer ybedfer ybedfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veprbl @ybedfer