Apply suggestions from code review

eic · Oct 19, 2024 · 0faa12d · 0faa12d
1 parent 3c483cd
commit 0faa12d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/compact/hcal/lfhcal.xml b/compact/hcal/lfhcal.xml
@@ -59,10 +59,6 @@
     <vis name="LFHCAL8MModVis"          ref="AnlBlue"       showDaughters="true"  visible="true"/>
     <vis name="LFHCAL4MModVis"          ref="AnlViolet"     showDaughters="true"  visible="true"/>
     <vis name="LFHCAL8MModOuter"        ref="AnlBlue"       showDaughters="true"  visible="true"/>
-
-    <!-- <vis name="LFHCAL8MModVis"          ref="AnlBlue"       showDaughters="true"  visible="false"/>
-    <vis name="LFHCAL4MModVis"          ref="AnlViolet"     showDaughters="true"  visible="false"/>
-    <vis name="LFHCAL8MModOuter"        ref="AnlBlue"       showDaughters="false"  visible="false"/> -->
     <vis name="LFHCALLayerScintVis"     ref="AnlLight_Gray" showDaughters="false" visible="true"/>
     <vis name="LFHCALLayerSteelVis"     ref="AnlRed"        showDaughters="false" visible="true"/>
     <vis name="LFHCALLayerTungstenVis"  ref="AnlViolet"     showDaughters="false" visible="true"/>

diff --git a/src/LFHCAL_geo.cpp b/src/LFHCAL_geo.cpp
@@ -1126,7 +1126,6 @@ static Ref_t createDetector(Detector& desc, xml_h handle, SensitiveDetector sens
 
     // Placing modules in world volume
     auto tr8M = Transform3D(Position(-pos8M[e].x, -pos8M[e].y, pos8M[e].z));
-    // Transform3D(Position(-pos8M[e].x - 0.5 * eightM_params.mod_width, -pos8M[e].y, pos8M[e].z));
     phv = assembly.placeVolume(eightMassembly, tr8M);
     phv.addPhysVolID("moduleIDx", moduleIDx)
         .addPhysVolID("moduleIDy", moduleIDy)
@@ -1165,7 +1164,6 @@ static Ref_t createDetector(Detector& desc, xml_h handle, SensitiveDetector sens
                    _toString(moduleIDy));
     }
     auto tr4M = Transform3D(Position(-pos4M[f].x, -pos4M[f].y, pos4M[f].z));
-    // Transform3D(Position(-pos4M[f].x - 0.5 * fourM_params.mod_width, -pos4M[f].y, pos4M[f].z));
     phv = assembly.placeVolume(fourMassembly, tr4M);
     phv.addPhysVolID("moduleIDx", moduleIDx)
         .addPhysVolID("moduleIDy", moduleIDy)