-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix:
arches
should have no forward ecal or hcal inserts (#239)
### Briefly, what does this PR introduce? This removes the forward ecal and hcal inserts from the `arches` configuration. It also (necessarily) introduces different handling for the hcal systems, which until now were all included through `hcal.xml`. That didn't allow for different hcal configurations. Now all hcal components are included directly from the `epic.xml.jinja2` template. ### What kind of change does this PR introduce? - [X] Bug fix (issue: arches should not have inserts) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [X] Changes have been communicated to collaborators - @johnlajoie This may affect hcal barrel inclusion since it modifies the jinja template which you were editing too. - @rymilton @sly2j As discussed on Mattermost. ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes, `arches` will have no more inserts. `brycecanyon` has inserts.
- Loading branch information
Showing
9 changed files
with
42 additions
and
21 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,7 @@ features: | |
barrel_sciglass | ||
backward_PbWO4 | ||
hcal: | ||
forward: | ||
forward_insert: | ||
barrel: | ||
backward: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,7 @@ features: | |
backward_PbWO4 | ||
solenoid: | ||
hcal: | ||
forward: | ||
forward_insert: | ||
barrel: | ||
backward: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,9 @@ features: | |
backward_PbWO4: | ||
solenoid: | ||
hcal: | ||
forward: | ||
forward_insert: | ||
barrel: | ||
backward: | ||
farforward: | ||
farbackward: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,9 @@ features: | |
backward_PbWO4: | ||
solenoid: | ||
hcal: | ||
forward: | ||
forward_insert: | ||
barrel: | ||
backward: | ||
farforward: | ||
farbackward: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,5 +21,9 @@ features: | |
backward_PbWO4: | ||
solenoid: | ||
hcal: | ||
forward: | ||
forward_insert: | ||
barrel: | ||
backward: | ||
farforward: | ||
farbackward: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters