Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pfRICH Sensor material parameter move to xml file #772

Closed
billlee77 opened this issue Aug 21, 2024 · 0 comments · Fixed by #775
Closed

pfRICH Sensor material parameter move to xml file #772

billlee77 opened this issue Aug 21, 2024 · 0 comments · Fixed by #775
Assignees
@billlee77 @kkauder @RomanTkachenko-dev

Comments

@billlee77
Copy link
Contributor

Is your feature request related to a problem? Please describe.
pfRICH Sensor material parameter move to xml file, including, window, ASIC readout, etc.

Describe the solution you'd like
Parameters are currently hardcoded, we need to move them to the xml file

Describe alternatives you've considered
None

Additional context
N/A
@RomanTkachenko-dev RomanTkachenko-dev linked a pull request Aug 28, 2024 that will close this issue
Move sensor material parameters to XML file #775
Merged
7 tasks
@RomanTkachenko-dev RomanTkachenko-dev mentioned this issue Aug 28, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2024
@RomanTkachenko-dev @pre-commit-ci
@billlee77 @veprbl
Move sensor material parameters to XML file (#775)
4c6c58a 
### Briefly, what does this PR introduce?
Move sensor material parameters to XML file

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #772)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: billlee77 <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billlee77 billlee77

@kkauder kkauder

@RomanTkachenko-dev RomanTkachenko-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move sensor material parameters to XML file eic/epic
3 participants
@billlee77 @kkauder @RomanTkachenko-dev