Move sensor material parameters to XML file #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: backward
veprbl
reviewed
Sep 10, 2024
|
@wdconinc @kkauder @veprbl Hi Wouter, Kolja, and Dimitry, Please take a 2nd look at the pull request, we made appropriate changes to define material differently, could you review and provide further comments? Also, I am not sure why there is still a check that fails, and I am not sure it is related to our changes. |
veprbl
approved these changes
Sep 25, 2024
|
@billlee77 This is good. Thank you for addressing the comments! |
|
(the validate-material-map will fail and that's currently expected) |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
veprbl
deleted the
772-pfrich-sensor-material-parameter-move-to-xml-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Move sensor material parameters to XML file
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?