-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add header to compact files with liaisons #64
base: main
Are you sure you want to change the base?
Conversation
rymilton is responsible for the HCal insert and ECal insert (latter is not listed and still under development). Calorimetry members from UCLA & UCR will discuss the other forward calorimetry systems during a meeting tomorrow. |
@mposik1983 as liaison for MPGDs. |
Added |
Zhongling Ji ( @jizhongling ) will be the liaison for the forward ECal. |
487d03e
to
ee051c4
Compare
ad97306
to
5dd0631
Compare
@kkauder See here for other identified DSC contacts with GitHub handles. |
At this point we do not have a way to make it apparent who is the POC for each detector system. This adds an `info` header block to xml files with the `author`'s github handle for use in pull request review requests and assignment. Note, `author` is the prescribed attribute in the [XML schema definition](https://www.lcsim.org/schemas/compact/1.0/compact.xsd) but it is intended to be interpreted as liaision. Multiple values for `author` can be added as a comma-separated list, so they can all be requested for review.
5dd0631
to
a8d9eb0
Compare
@wdconinc, can you please split TOF into Barrel TOF and Forward TOF, and have me as the BTOF Liaison and @nschmidtALICE Nicolas Schmidt (ORNL) as the FTOF Liaison? Thanks. Zhenyu |
Do we miss Backward HCal here? |
Yes, would be @lkosarz. |
At this point we do not have a way to make it apparent who is the POC for each detector system. This adds an
info
header block to xml files with theauthor
's github handle for use in pull request review requests and assignment.Note,
author
is the prescribed attribute in the XML schema definition but it is intended to be interpreted as liaision. Multiple values forauthor
can be added as a comma-separated list, so they can all be requested for review.TODO (add name, check box when implemented):