Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add header to compact files with liaisons #64

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 18, 2022

At this point we do not have a way to make it apparent who is the POC for each detector system. This adds an info header block to xml files with the author's github handle for use in pull request review requests and assignment.

Note, author is the prescribed attribute in the XML schema definition but it is intended to be interpreted as liaision. Multiple values for author can be added as a comma-separated list, so they can all be requested for review.

TODO (add name, check box when implemented):

@wdconinc wdconinc self-assigned this Aug 18, 2022
@wdconinc
Copy link
Contributor Author

wdconinc commented Aug 18, 2022

@wdconinc wdconinc changed the title feat: add header to compact file with liaisons feat: add header to compact files with liaisons Aug 18, 2022
@wdconinc wdconinc requested a review from sly2j August 18, 2022 17:47
@rymilton
Copy link
Contributor

rymilton commented Aug 18, 2022

rymilton is responsible for the HCal insert and ECal insert (latter is not listed and still under development). Calorimetry members from UCLA & UCR will discuss the other forward calorimetry systems during a meeting tomorrow.

@wdconinc
Copy link
Contributor Author

@mposik1983 as liaison for MPGDs.

@wdconinc
Copy link
Contributor Author

Added status attribute. development until blessed, at which point production, and deprecated when dead.

@jizhongling
Copy link
Contributor

Zhongling Ji ( @jizhongling ) will be the liaison for the forward ECal.

@veprbl veprbl added the topic: documentation Improvements or additions to documentation label Aug 20, 2022
@wdconinc
Copy link
Contributor Author

@wdconinc wdconinc force-pushed the subsystem-info-block branch from 487d03e to ee051c4 Compare August 26, 2022 01:57
@veprbl veprbl added the topic: infrastructure Regarding build system, CI, CD label Oct 1, 2022
@wdconinc wdconinc added this to the 22.12.0 milestone Nov 4, 2022
@wdconinc wdconinc force-pushed the subsystem-info-block branch from ad97306 to 5dd0631 Compare November 24, 2022 16:57
@github-actions github-actions bot added topic: barrel Mid-rapidity detectors topic: calorimetry topic: forward Positive-rapidity detectors (hadron-going side) topic: PID Particle identification topic: tracking and removed topic: documentation Improvements or additions to documentation labels Nov 24, 2022
@veprbl veprbl modified the milestones: 22.12.0, 23.01.0 Jan 5, 2023
@veprbl veprbl modified the milestones: 23.01.0, 23.02.0 Feb 7, 2023
@wdconinc
Copy link
Contributor Author

@kkauder See here for other identified DSC contacts with GitHub handles.

At this point we do not have a way to make it apparent who is the POC for each detector system. This adds an `info` header block to xml files with the `author`'s github handle for use in pull request review requests and assignment.

Note, `author` is the prescribed attribute in the [XML schema definition](https://www.lcsim.org/schemas/compact/1.0/compact.xsd) but it is intended to be interpreted as liaision. Multiple values for `author` can be added as a comma-separated list, so they can all be requested for review.
@wdconinc wdconinc force-pushed the subsystem-info-block branch from 5dd0631 to a8d9eb0 Compare October 14, 2023 15:52
@yezhenyu2003
Copy link
Contributor

@wdconinc, can you please split TOF into Barrel TOF and Forward TOF, and have me as the BTOF Liaison and @nschmidtALICE Nicolas Schmidt (ORNL) as the FTOF Liaison? Thanks. Zhenyu

@Chao1009
Copy link
Contributor

Do we miss Backward HCal here?

@wdconinc
Copy link
Contributor Author

Do we miss Backward HCal here?

Yes, would be @lkosarz.

@niwgit
Copy link
Contributor

niwgit commented Oct 20, 2023

@Chao1009, can you add me @niwgit for DIRC?

Thanks,
Nilanga

@veprbl veprbl removed this from the 23.02.0 milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: barrel Mid-rapidity detectors topic: calorimetry topic: far-backward topic: forward Positive-rapidity detectors (hadron-going side) topic: infrastructure Regarding build system, CI, CD topic: PID Particle identification topic: simulation topic: tracking
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

10 participants