-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tof new gemo #790
Closed
Closed
Tof new gemo #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kerWithFrame_geo.cpp, but it is modified to accommodate multile sensors with dead spaces.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Dmitry Kalinkin <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Endcap TOF geometry modified to match the newest technical drawings from https://indico.bnl.gov/event/24949/attachments/57520/98759/ePICTOF_WP2_FTOFLayout_09272024v2.pdf.
The current epic geometry has each module located separately. But the newest drawing shows that a single power board house multiple modules together. This PR groups modules together according to the aforementioned drawing.
Furthermore, the current epic geometry shows that sensors are placed facing front and backing alternatively across rows. However, the latest drawing shows that ETOF are double sided on every row, but with sensors placed below the service hybrid on the front side, and above the service hybrid on the other side. Each module now contains 4 small sensors instead of one big sensor.
Here's the updated ETOF power board configuration,
Front:
Back:
Here are the sensors configuration when I take the PB out,
Front:
Back:
Barrel TOF geometry is also modified because it was decided here: https://indico.bnl.gov/event/20727/contributions/93749/attachments/56159/96118/2024_07_26_TOF_MECH_FLEX.pdf that there should be sensors on both sides of the BTOF stave. Here's an illustration with only half the stave drawn (if I draw all staves, the backward facing sensors will be covered by neighboring staves):
(Please ignore the highlighted sensor. This is a screenshot of my previous presentations and that part is not relevant to this illustration of TOF geometry.)
The final ETOF+BTOF geometry from this pull request:
Does this PR change default behavior?