Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lfhcal geoupdate #798

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Lfhcal geoupdate #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73eba84
push of new geometry changes for lfhcal
nschmidtALICE Oct 2, 2024
8d86f33
fixed offset of calorimeter with new design
nschmidtALICE Oct 3, 2024
2480463
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 14, 2024
3c483cd
Merge branch 'main' into lfhcal_geoupdate
FriederikeBock Oct 14, 2024
0faa12d
Apply suggestions from code review
veprbl Oct 19, 2024
2b6845e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 19, 2024
d60509c
Merge branch 'main' into lfhcal_geoupdate
veprbl Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compact/definitions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ Service gaps in FW direction (before endcapP ECAL) and BW direction (before endc

<constant name="LFHCAL_zmin" value="EcalEndcapP_zmin + EcalEndcapP_length"/>
<comment> LFHCAL is 140 cm total, but current implementation leaves the final 10 cm empty </comment>
<constant name="LFHCAL_length" value="140.0*cm"/>
<constant name="LFHCAL_length" value="134.54*cm"/>
<constant name="LFHCAL_zmax" value="LFHCAL_zmin + LFHCAL_length"/>

<constant name="HcalEndcapPInsert_zmin" value="EcalEndcapP_zmin + EcalEndcapP_length"/>
Expand Down
Loading