Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file for eHe3 #806

Closed
wants to merge 2 commits into from
Closed

Conversation

Meatbally2
Copy link
Contributor

Briefly, what does this PR introduce?

I would like to run simulation for e He3 scattering, but It seems like the field was added for this configuration, but the .yml file was not. So I added the configuration file for eHe3 beams.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [ x ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@veprbl
Copy link
Member

veprbl commented Nov 14, 2024

Could you, please, add your affiliation to your github profile, @Meatbally2. That is a requirement for @eic membership.

@Meatbally2
Copy link
Contributor Author

Hi,

I updated my profile. Please let me know if the affiliation is not visible or if I should add more information. Thank you!

@veprbl
Copy link
Member

veprbl commented Nov 14, 2024

@Meatbally2 I sent you an invite. Please, push your change as a branch to this repository instead of your own fork. Then, resubmit a PR from that branch, this PR can be closed. That will allow for CI checks to run.

@Meatbally2
Copy link
Contributor Author

Thank you, i will submit a new pull request from the branch feature-add-eHe3-config now.

@Meatbally2 Meatbally2 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants