Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eiffel Events .NET SDK to PROJECTS and CONTACT #122

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

erkist
Copy link
Contributor

@erkist erkist commented Dec 4, 2021

Applicable Issues

Fixes #121

Description of the Change

Add Eiffel Events .NET SDK to PROJECTS and CONTACT as per PROJECT_LIFECYCLE

Alternate Designs

N/A

Benefits

Project and contact information available to others.

Possible Drawbacks

N/A

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Erik Sternerson, [email protected]

@erkist
Copy link
Contributor Author

erkist commented Dec 4, 2021

Note: The repo has not been created yet, this PR should not be merged until the repo exists.

@erkist erkist marked this pull request as ready for review December 6, 2021 10:45
@erkist erkist requested a review from a team as a code owner December 6, 2021 10:45
@magnusbaeck
Copy link
Member

I was just about to merge this PR but I noticed that [email protected] doesn't appear to have been created. Was this overlooked @erkist?

Also, please add a CODEOWNERS file to your repo (see #7).

@erkist
Copy link
Contributor Author

erkist commented Dec 17, 2021

I was just about to merge this PR but I noticed that [email protected] doesn't appear to have been created. Was this overlooked @erkist?

I think I have created it? Maybe there is some setting I have missed? It was a few years since I last created a google group...

image

Also, please add a CODEOWNERS file to your repo (see #7).

Will do!

@magnusbaeck
Copy link
Member

I think I have created it? Maybe there is some setting I have missed? It was a few years since I last created a google group...

Ah, you probably have the "Who can see the group" setting set to "Group members" (which probably is the default). I don't think that's a problem.

@magnusbaeck magnusbaeck merged commit d2339e3 into eiffel-community:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New project "eiffelevents-sdk-dotnet"
5 participants