Merge pull request #558 from eik-lib/fix_tests_for_node_gt_16

Fix tests for node greater than 16, upgrade Node to v20
eik-lib · Jul 29, 2024 · ee93a4b · ee93a4b
2 parents 68d9b4c + 1d7b363
commit ee93a4b
Show file tree

Hide file tree

Showing 18 changed files with 91 additions and 25 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
 
       - name: Install dependencies
         run: npm install

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest] #, windows-latest]
-        node-version: [16]
+        node-version: [20]
 
     runs-on: ${{ matrix.os }}
 

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16
+20
diff --git a/test/alias.test.js b/test/alias.test.js
@@ -17,7 +17,10 @@ beforeEach(async (t) => {
     const memSink = new sink.MEM();
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/integration/alias.test.js b/test/integration/alias.test.js
@@ -26,7 +26,10 @@ beforeEach(async (t) => {
     const memSink = new sink.MEM();
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
     const eik = join(__dirname, '../../index.js');
 

diff --git a/test/integration/integrity.test.js b/test/integration/integrity.test.js
@@ -24,7 +24,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
 
     const token = await cli.login({

diff --git a/test/integration/login.test.js b/test/integration/login.test.js
@@ -25,7 +25,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
 

diff --git a/test/integration/map.test.js b/test/integration/map.test.js
@@ -25,7 +25,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
 
     const token = await cli.login({

diff --git a/test/integration/meta.test.js b/test/integration/meta.test.js
@@ -24,7 +24,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
     const eik = join(__dirname, '../../index.js');
 

diff --git a/test/integration/package.test.js b/test/integration/package.test.js
@@ -25,7 +25,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const folder = await fs.mkdtemp(join(os.tmpdir(), basename(__filename)));
 
     const token = await cli.login({

diff --git a/test/integrity.test.js b/test/integrity.test.js
@@ -14,7 +14,10 @@ beforeEach(async (t) => {
     const memSink = new sink.MEM();
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/login.test.js b/test/login.test.js
@@ -14,7 +14,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     t.context.server = server;
     t.context.address = address;
 });

diff --git a/test/meta.test.js b/test/meta.test.js
@@ -17,7 +17,10 @@ beforeEach(async (t) => {
     const memSink = new sink.MEM();
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/publish-files-definitions.test.js b/test/publish-files-definitions.test.js
@@ -26,7 +26,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/publish.map.test.js b/test/publish.map.test.js
@@ -17,7 +17,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/publish.package.test.js b/test/publish.package.test.js
@@ -17,7 +17,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,

diff --git a/test/utils.test.js b/test/utils.test.js
@@ -76,7 +76,10 @@ test('fetch latest version for a given published bundle', async (t) => {
             [2, { version: '2.1.8' }],
         ],
     }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const version = await f.latestVersion(address, 'pkg', 'foo');
 
@@ -93,7 +96,10 @@ test('fetch latest version, filtered by major, for a given published bundle', as
             [2, { version: '2.1.8' }],
         ],
     }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const version = await f.latestVersion(address, 'pkg', 'foo', 1);
 
@@ -104,7 +110,10 @@ test('fetch latest version, filtered by major, for a given published bundle', as
 
 test('fetch latest version for a given published bundle, non existant bundle on server', async (t) => {
     const server = fastify();
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     try {
         await f.latestVersion(address, 'pkg', 'foo');
@@ -122,7 +131,10 @@ test('fetch latest version for a given published bundle, non existant bundle on
 test('fetch latest version, filtered by major, for a given published bundle', async (t) => {
     const server = fastify();
     server.get('/pkg/foo', async () => '');
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     try {
         await f.latestVersion(address, 'pkg', 'foo');
@@ -140,7 +152,10 @@ test('fetch latest version, filtered by major, for a given published bundle', as
 test('fetch latest version, invalid versions returned by server', async (t) => {
     const server = fastify();
     server.get('/pkg/foo', async () => ({ versions: 1 }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     t.rejects(
         f.latestVersion(address, 'pkg', 'foo'),
@@ -158,7 +173,10 @@ test('fetch latest version, invalid versions keys returned by server', async (t)
             ['also not a number', 2],
         ],
     }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     t.rejects(
         f.latestVersion(address, 'pkg', 'foo'),
@@ -174,7 +192,10 @@ test('fetch latest version, no bundles yet published', async (t) => {
         latest: {},
         versions: [],
     }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const version = await f.latestVersion(address, 'pkg', 'foo');
 
@@ -199,7 +220,10 @@ test('fetch remote hash for a given version', async (t) => {
             },
         ],
     }));
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
     const result = await f.integrity(address, 'pkg', 'foo', '1.0.0');
 
     t.equal(

diff --git a/test/version.test.js b/test/version.test.js
@@ -16,7 +16,10 @@ beforeEach(async (t) => {
     const server = fastify({ logger: false });
     const service = new EikService({ customSink: memSink });
     server.register(service.api());
-    const address = await server.listen();
+    const address = await server.listen({
+        host: '127.0.0.1',
+        port: 0,
+    });
 
     const token = await cli.login({
         server: address,