chore: convert codebase to ESM #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: JavaScript API is now ESM only and no longer supports CJS
digitalsadhu
requested review from
leftieFriele,
wkillerud,
tor0405,
flatoy and
trygve-lie
leftieFriele
approved these changes
Jul 30, 2024
wkillerud
reviewed
Jul 30, 2024
| import scrollIntoView from 'scroll-into-view-if-needed'; | ||
|
|
||
| const main = () => { | ||
| // eslint-disable-next-line no-undef | ||
| const node = document.getElementById('hero'); |
There was a problem hiding this comment.
Not that this is the part under test, but I think this missing line is what eslint is complaining about 😅
+1, would be nice to do a sweep of the open PRs and bump deps that would be a breaking change. |
|
Might be worth either merging this into a "next" and then updating dept, then merging into main or doing dep updates as part of this PR to avoid multiple breaking changes |
wkillerud
approved these changes
Jul 31, 2024
|
This PR is now against next and I'll merge it into that and continue work updating dependencies from there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: JavaScript API is now ESM only and no longer supports CJS