Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese translation #1235

Closed
wants to merge 3 commits into from
Closed

Japanese translation #1235

wants to merge 3 commits into from

Conversation

dinoue
Copy link
Contributor

@dinoue dinoue commented Nov 8, 2023

Some brush ups.

@eikek
Copy link
Owner

eikek commented Nov 8, 2023

I think these commits together don't add up to any change. Perhaps throw away the last two? (or rebase the "Brush Up" against a new branch off of master?)

@dinoue
Copy link
Contributor Author

dinoue commented Nov 9, 2023

Yes, you are right, @eikek.
The last two are just commits to catch up your master branch.
Please throw them away.

@eikek
Copy link
Owner

eikek commented Nov 9, 2023

I don't think I'm able to (can't write to your repo, probably). You can do a git reset --hard HEAD~2 and do a force push - that should fix it.

@dinoue
Copy link
Contributor Author

dinoue commented Nov 18, 2023

Sorry, I took long time to reply.
I considered then maybe I took wrong way to make pull request.
I close this one, and make another one.

@dinoue dinoue closed this Nov 18, 2023
@dinoue dinoue deleted the JapaneseTranslation branch January 13, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants