Deprecate GenericAnnotatedTypeFactory#addComputedTypeAnnotations(Tree, AnnotatedTypeMirror, boolean)
#796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdietl
requested changes
Jun 27, 2024
framework/src/main/java/org/checkerframework/framework/type/AnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <[email protected]>
Added a changelog entry and remove document no longer useful in the manual. |
wmdietl
changed the title
GenericAnnotatedTypeFactory#addComputedTypeAnnotations(Tree, AnnotatedTypeMirror, boolean)
wmdietl
requested changes
Jun 28, 2024
.../main/java/org/checkerframework/checker/index/upperbound/UpperBoundAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
.../main/java/org/checkerframework/checker/index/upperbound/UpperBoundAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Werner Dietl <[email protected]>
Ao-senXiong
commented
Jun 28, 2024
Co-authored-by: Werner Dietl <[email protected]>
wmdietl
requested changes
Jul 7, 2024
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
.../main/java/org/checkerframework/checker/index/lowerbound/LowerBoundAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
.../main/java/org/checkerframework/checker/index/upperbound/UpperBoundAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
checker/src/main/java/org/checkerframework/checker/lock/LockAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Show resolved
Hide resolved
docs/CHANGELOG.md
Outdated
| @@ -5,6 +5,10 @@ Version 3.42.0-eisop4 (April ?, 2024) | |||
|
|
|||
| **Implementation details:** | |||
|
|
|||
| Deprecated the `GenericAnnotatedTypeFactory#addComputedTypeAnnotations(Tree, AnnotatedTypeMirror, boolean)` overload. | |||
| Instead, set `GenericAnnotatedTypeFactory#useFlow` appropriately and | |||
There was a problem hiding this comment.
I also see deletions in creating-a-checker.tex, no additions. Did you forget to add your changes in the manual?
Co-authored-by: Werner Dietl <[email protected]>
I forget to commit my changes. Now it is there. |
wmdietl
reviewed
Jul 9, 2024
wmdietl
reviewed
Jul 9, 2024
| } | ||
|
|
||
| @Override | ||
| protected void addComputedTypeAnnotations(Tree tree, AnnotatedTypeMirror type) { |
There was a problem hiding this comment.
An @see to addComputedTypeAnnotationsWithoutFlow from here would be good, to connect them in both directions.
There was a problem hiding this comment.
Updated with inheritance doc and @see tag.
wmdietl
reviewed
Jul 9, 2024
| @@ -2014,9 +2013,35 @@ public AnnotatedTypeMirror getDefaultAnnotations(Tree tree, AnnotatedTypeMirror | |||
| * @param tree an AST node | |||
| * @param type the type obtained from tree | |||
| * @param iUseFlow whether to use information from dataflow analysis | |||
| * @deprecated use {@link #addComputedTypeAnnotations(Tree, AnnotatedTypeMirror)} instead | |||
There was a problem hiding this comment.
Also mention addComputedTypeAnnotationsWithoutFlow here?
There was a problem hiding this comment.
Sure, added in new commit.
wmdietl
reviewed
Jul 9, 2024
Co-authored-by: Werner Dietl <[email protected]>
wmdietl
approved these changes
Jul 10, 2024
framework/src/main/java/org/checkerframework/framework/type/GenericAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
wmdietl
changed the title
GenericAnnotatedTypeFactory#addComputedTypeAnnotations(Tree, AnnotatedTypeMirror, boolean)GenericAnnotatedTypeFactory#addComputedTypeAnnotations(Tree, AnnotatedTypeMirror, boolean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from opprop#215, we can close that PR after merge this one.