Add smooth corners to <Card>
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
sashachabin
force-pushed
the
feature/card-smooth-corners
branch
2 times, most recently
from
6fe6d02 to
11c0183
Compare
hiba9201
reviewed
Nov 22, 2023
| }); | ||
| } | ||
|
|
||
| export function useSmoothCorners(cardRef: MutableRefObject<HTMLElement>) { |
There was a problem hiding this comment.
it's not always card, right?)
There was a problem hiding this comment.
Yep! Added this to Marquee ;)
| @@ -53,15 +53,12 @@ | |||
| .MapVehiclesSidebarVehicleInfo { | |||
There was a problem hiding this comment.
Please check if changes in this file are valid?
There was a problem hiding this comment.
Committed unnecessary changes. Thank you for your attention!
hiba9201
reviewed
Nov 22, 2023
| const cardRef = useRef<HTMLAnchorElement>(null); | ||
| const cardTitleRef = useRef<HTMLDivElement>(null); | ||
| useSmoothCorners(cardRef); | ||
| useSmoothCorners(cardTitleRef); |
There was a problem hiding this comment.
We don't really need smooth corners for all titles? Only for those that have background
There was a problem hiding this comment.
Added condition with bgcolor
sashachabin
force-pushed
the
feature/card-smooth-corners
branch
from
144d4b9 to
11c0183
Compare
|
sashachabin
force-pushed
the
feature/card-smooth-corners
branch
from
373137c to
723d4de
Compare
hiba9201
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 0.8 smooth corners to
<Card>with ResizeObserver & figma-squircle