feat: rename command file to nuke and add q alias for --quiet #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdirkse
force-pushed
the
add-quiet-alias
branch
3 times, most recently
from
eebbb05 to
36fa68e
Compare
mdirkse
changed the title
|
@ekristen any chance of a review? |
|
hey @mdirkse somehow I totally missed this but I was out sick last week so my apologies. Reviewing now. |
ekristen
approved these changes
Mar 7, 2024
|
@mdirkse are you setup to do signed commits? I'd prefer it to be signed, if not, I can skip it this time. Otherwise I'm good with it and merge, thanks for pinging me again about it. |
|
No problem, signed! |
|
I'll be moving out of beta soon! |
|
🎉 This PR is included in version 3.0.0-beta.31 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
corybekk
pushed a commit
to oreillymedia/aws-nuke-v2
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nukecommand tonuke.goin line with the name of the other command files-qalias for the--quietswitch on thenukecommand, as this was present in the originalaws-nukeand is also a pretty universal alias