Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag support and tests for SageMakerDomain #111

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

ekristen
Copy link
Owner

@ekristen ekristen commented Mar 7, 2024

This adds tags for SageMakerDomain and also introduces mocks for SageMaker and unit tests for SageMakerDomain for the List and the Remove function.

Resolves #110

@ekristen ekristen force-pushed the sagemakerdomain-tags branch from ee57d54 to 2408539 Compare March 7, 2024 22:43
@ekristen
Copy link
Owner Author

ekristen commented Mar 7, 2024

@YuriGal let me know what OS you are on, I can provide a test build.

@YuriGal
Copy link

YuriGal commented Mar 7, 2024

I run it in AWS CodeBuild, Linux.

@ekristen
Copy link
Owner Author

ekristen commented Mar 7, 2024

Builds are too big to upload here, finding another solution for providing intermediate builds.

@ekristen
Copy link
Owner Author

ekristen commented Mar 8, 2024

@YuriGal can you access this link? It contains all the binaries but the linux/amd64 is there -- should be able to test https://github.com/ekristen/aws-nuke/actions/runs/8196507179/artifacts/1307766418

@YuriGal
Copy link

YuriGal commented Mar 8, 2024

Should be able to, need to reconfigure my setup a bit, but should be able to.

@YuriGal
Copy link

YuriGal commented Mar 8, 2024

Sorry having issues doing it from CI environment, could you publish it as pre-release, so I can get it the regular way?

@ekristen ekristen merged commit 089df08 into main Mar 8, 2024
5 checks passed
@ekristen ekristen deleted the sagemakerdomain-tags branch March 8, 2024 02:41
@ekristen
Copy link
Owner Author

ekristen commented Mar 8, 2024

🎉 This PR is included in version 3.0.0-beta.32 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ekristen
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags are not respected?
2 participants