- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tag support and tests for SageMakerDomain #111
Conversation
ee57d54
to
2408539
Compare
@YuriGal let me know what OS you are on, I can provide a test build. |
I run it in AWS CodeBuild, Linux. |
Builds are too big to upload here, finding another solution for providing intermediate builds. |
@YuriGal can you access this link? It contains all the binaries but the linux/amd64 is there -- should be able to test https://github.com/ekristen/aws-nuke/actions/runs/8196507179/artifacts/1307766418 |
Should be able to, need to reconfigure my setup a bit, but should be able to. |
Sorry having issues doing it from CI environment, could you publish it as pre-release, so I can get it the regular way? |
🎉 This PR is included in version 3.0.0-beta.32 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This adds tags for
SageMakerDomain
and also introduces mocks forSageMaker
and unit tests forSageMakerDomain
for theList
and theRemove
function.Resolves #110