Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing max-wait-retries #121

Merged
merged 1 commit into from
Mar 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions pkg/commands/nuke/nuke.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,14 @@ func execute(c *cli.Context) error { //nolint:funlen,gocyclo

// Create the parameters object that will be used to configure the nuke process.
params := &libnuke.Parameters{
Force: c.Bool("force"),
ForceSleep: c.Int("force-sleep"),
Quiet: c.Bool("quiet"),
NoDryRun: c.Bool("no-dry-run"),
Includes: c.StringSlice("include"),
Excludes: c.StringSlice("exclude"),
Alternatives: c.StringSlice("cloud-control"),
Force: c.Bool("force"),
ForceSleep: c.Int("force-sleep"),
Quiet: c.Bool("quiet"),
NoDryRun: c.Bool("no-dry-run"),
Includes: c.StringSlice("include"),
Excludes: c.StringSlice("exclude"),
Alternatives: c.StringSlice("cloud-control"),
MaxWaitRetries: c.Int("max-wait-retries"),
}

if len(c.StringSlice("feature-flag")) > 0 {
Expand Down Expand Up @@ -232,10 +233,6 @@ func init() { //nolint:funlen
Name: "no-dry-run",
Usage: "actually run the removal of the resources after discovery",
},
&cli.BoolFlag{
Name: "no-alias-check",
Usage: "disable aws account alias check - requires entry in config as well",
},
&cli.BoolFlag{
Name: "no-prompt",
Usage: "disable prompting for verification to run",
Expand All @@ -247,6 +244,14 @@ func init() { //nolint:funlen
Value: 10,
Aliases: []string{"force-sleep"},
},
&cli.IntFlag{
Name: "max-wait-retries",
Usage: "maximum number of retries to wait for dependencies to be removed",
},
&cli.BoolFlag{
Name: "no-alias-check",
Usage: "disable aws account alias check - requires entry in config as well",
},
&cli.StringSliceFlag{
Name: "feature-flag",
Usage: "enable experimental behaviors that may not be fully tested or supported",
Expand Down