feat(iottwinmaker): add workspace, component type, entity, scene, syncjob #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New resources
Non-nukeable resources are marked as filtered. Scan with feature activated Nuke with feature activated |
npellegrin
force-pushed
the
feature/iot-twinmaker
branch
7 times, most recently
from
c5b222c to
5b5eda8
Compare
|
Interesting on the endpoint configuration. I'm working on AWS SDK v2 support which is going to require a bit of work around endpoints. What happens if you do not provide the endpoint configuration? How do the resources behave? I can test later, just don't have time at the moment. |
ekristen
requested changes
Nov 17, 2024
There was a problem hiding this comment.
@npellegrin thanks again for your contribution. If you don't mind please see my comments on the other pull request, it talks about renaming the pointers from like f to r and updating how the properties function works.
If you'd prefer I can push a commit to do the standardization changes instead.
I do appreciate the effort and the support! It is much appreciated.
If I do not add the endpoint, the resource is ignored and I can see the error in debug logs |
Thanks for the quick feedback! I will do the changes in both PR :) |
npellegrin
force-pushed
the
feature/iot-twinmaker
branch
2 times, most recently
from
97fb1f8 to
d64cbf0
Compare
npellegrin
force-pushed
the
feature/iot-twinmaker
branch
from
d64cbf0 to
4a2ec59
Compare
|
I fixed the endpoint issue with the same trick already in place for s3control, no need to add a specific YAML config with this resource :) |
ekristen
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 3.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
IMPORTANT: To have the feature working, I had to give the endpoint in aws-nuke configuration. I guess it is the logic in pkg/awsutil/session.go not supporting the particular IoT TwinMaker endpoints. IoT TwinMaker have two endpoints:
The configuration to add to test this feature is: