feat: add CloudWatchLogGroup RetentionInDays #489
Conversation
There was a problem hiding this comment.
@ayogun I'm not quite sure I understand what you are going for here? It's not clear to me why you are modifying the response from AWS? If RetentionInDays is nil coming from AWS why are you wanting to set it to 0? Is it just so that the value is present and you can make the property appear for filtering?
Hey Erik, it's my first time I touch GO and I'm trying my way out of here. This is why it was a draft PR. I'm also not sure what I am doing but trying to achieve that outcome:
What do you think about PR now? Should I delete set to 0 part? Anyway, thank you very much for due diligence!!! |
|
@ayogun welcome welcome welcome! Thanks for letting me know. I have a couple more suggestions for you, so we can do it a couple different ways. I can make a few more suggestions on the PR, or I can do the modifications on your PR for you to see. |
OMG, you are awesome! Please do the changes, and let me learn by watching the master ❤️ BTW, Happy happy new year! |
|
lol, you are too kind. I'll do the changes later, probably won't be for a couple of hours. Happy New Year! |
|
@ayogun sorry I didn't get to this yesterday something came up, I will today though. |
No worries. I can't wait to work with you! 🤩 |
|
|
|
Closing this one as I can't manipulate your main branch, see the #494, I added a few more things while I was there. |
I intended to add
RetentionInDaysproperty to CloudWatchLogGroup